c8h4/postgresql
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Improve comment for OAT_POST_CREATE.

Browse source 
Clarify that the command counter may or may not have been incremented.

We may want to change the behavior to be more consistent, but until
that time, at least improve the comment.

Discussion: https://postgr.es/m/CAHoZxqvN2eoic_CvjsAvpryyLyA2xG8JmsyMtKFFJz_1oFhfOg%40mail.gmail.com
Reported-by: Mary Xu
This commit is contained in:
Jeff Davis 2022-09-20 10:41:34 -07:00
parent 3d53b9ef1a
commit bb44a6ba48
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/include/catalog/objectaccess.h
View file

@ -17,7 +17,9 @@
* *
* OAT_POST_CREATE should be invoked just after the object is created. * OAT_POST_CREATE should be invoked just after the object is created.
* Typically, this is done after inserting the primary catalog records and * Typically, this is done after inserting the primary catalog records and
* associated dependencies. * associated dependencies. The command counter may or may not be incremented
* at the time the hook is invoked; if not, the extension can use SnapshotSelf
* to get the new version of the tuple.
* *
* OAT_DROP should be invoked just before deletion of objects; typically * OAT_DROP should be invoked just before deletion of objects; typically
* deleteOneObject(). Its arguments are packed within ObjectAccessDrop. * deleteOneObject(). Its arguments are packed within ObjectAccessDrop.