c8h4/postgresql
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

pg_createsubscriber: Remove replication slot check on primary

Browse source 
It used to check if the replication slot exists and is active on
primary.  This check might fail on slow hosts because the replication
slot might not be active at the time of this check.

The current code obtains the replication slot name from the
primary_slot_name on standby and assumes the replication slot exists
and is active on primary.  If it doesn't exist, this tool will log an
error and continue.

Author: Euler Taveira <euler.taveira@enterprisedb.com>
Reviewed-by: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Discussion: https://www.postgresql.org/message-id/776c5cac-5ef5-4001-b1bc-5b698bc0c62a%40app.fastmail.com
This commit is contained in:
Peter Eisentraut 2024-06-17 10:48:17 +02:00
parent 04c8634c0c
commit b963913826
1 changed files with 1 additions and 47 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

48
src/bin/pg_basebackup/pg_createsubscriber.c
View file

@ -879,47 +879,6 @@ check_publisher(const struct LogicalRepInfo *dbinfo)
pg_log_debug("publisher: max_wal_senders: %d", max_walsenders);
pg_log_debug("publisher: current wal senders: %d", cur_walsenders);
/*
* If standby sets primary_slot_name, check if this replication slot is in
* use on primary for WAL retention purposes. This replication slot has no
* use after the transformation, hence, it will be removed at the end of
* this process.
*/
if (primary_slot_name)
{
PQExpBuffer str = createPQExpBuffer();
char *psn_esc = PQescapeLiteral(conn, primary_slot_name, strlen(primary_slot_name));
appendPQExpBuffer(str,
"SELECT 1 FROM pg_catalog.pg_replication_slots "
"WHERE active AND slot_name = %s",
psn_esc);
pg_free(psn_esc);
pg_log_debug("command is: %s", str->data);
res = PQexec(conn, str->data);
if (PQresultStatus(res) != PGRES_TUPLES_OK)
{
pg_log_error("could not obtain replication slot information: %s",
PQresultErrorMessage(res));
disconnect_database(conn, true);
}
if (PQntuples(res) != 1)
{
pg_log_error("could not obtain replication slot information: got %d rows, expected %d row",
PQntuples(res), 1);
disconnect_database(conn, true);
}
else
pg_log_info("primary has replication slot \"%s\"",
primary_slot_name);
PQclear(res);
}
disconnect_database(conn, false);
if (strcmp(wal_level, "logical") != 0)
@ -2061,12 +2020,7 @@ main(int argc, char **argv)
/* Check if the standby server is ready for logical replication */
check_subscriber(dbinfo);
/*
* Check if the primary server is ready for logical replication. This
* routine checks if a replication slot is in use on primary so it relies
* on check_subscriber() to obtain the primary_slot_name. That's why it is
* called after it.
*/
/* Check if the primary server is ready for logical replication */
check_publisher(dbinfo);
/*