c8h4/postgresql
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Add invariants check to get_useful_group_keys_orderings()

Browse source 
This commit introduces invariants checking of generated orderings
in get_useful_group_keys_orderings() for assert-enabled builds.

Discussion: https://postgr.es/m/a663f0f6-cbf6-49aa-af2e-234dc6768a07%40postgrespro.ru
Reported-by: Tom Lane
Author: Andrei Lepikhov
Reviewed-by: Alexander Korotkov, Pavel Borisov
This commit is contained in:
Alexander Korotkov 2024-06-06 13:42:47 +03:00
parent 199012a3d8
commit 91143c03d4
1 changed files with 28 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
src/backend/optimizer/path/pathkeys.c
View file

@ -561,6 +561,34 @@ get_useful_group_keys_orderings(PlannerInfo *root, Path *path)
}
}
#ifdef USE_ASSERT_CHECKING
{
PathKeyInfo *pinfo = linitial_node(PathKeyInfo, infos);
ListCell *lc;
/* Test consistency of info structures */
for_each_from(lc, infos, 1)
{
ListCell *lc1,
*lc2;
info = lfirst_node(PathKeyInfo, lc);
Assert(list_length(info->clauses) == list_length(pinfo->clauses));
Assert(list_length(info->pathkeys) == list_length(pinfo->pathkeys));
Assert(list_difference(info->clauses, pinfo->clauses) == NIL);
Assert(list_difference_ptr(info->pathkeys, pinfo->pathkeys) == NIL);
forboth(lc1, info->clauses, lc2, info->pathkeys)
{
SortGroupClause *sgc = lfirst_node(SortGroupClause, lc1);
PathKey *pk = lfirst_node(PathKey, lc2);
Assert(pk->pk_eclass->ec_sortref == sgc->tleSortGroupRef);
}
}
}
#endif
return infos;
}