c8h4/postgresql
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Use NULL instead of 0 for 'arg' argument in dshash_create() calls.

Browse source 
A couple of dshash_create() callers provide 0 for the 'void *arg'
argument, which might give readers the incorrect impression that
this is some sort of "flags" parameter.

Reviewed-by: Andy Fan
Discussion: https://postgr.es/m/20240119215941.GA1322079%40nathanxps13
This commit is contained in:
Nathan Bossart 2024-02-26 15:46:01 -06:00
parent 6979ea2638
commit 5fe08c006c
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/backend/replication/logical/launcher.c
View file

@ -1013,7 +1013,7 @@ logicalrep_launcher_attach_dshmem(void)
last_start_times_dsa = dsa_create(LWTRANCHE_LAUNCHER_DSA);
dsa_pin(last_start_times_dsa);
dsa_pin_mapping(last_start_times_dsa);
last_start_times = dshash_create(last_start_times_dsa, &dsh_params, 0);
last_start_times = dshash_create(last_start_times_dsa, &dsh_params, NULL);
/* Store handles in shared memory for other backends to use. */
LogicalRepCtx->last_start_dsa = dsa_get_handle(last_start_times_dsa);

2
src/backend/utils/activity/pgstat_shmem.c
View file

@ -180,7 +180,7 @@ StatsShmemInit(void)
* With the limit in place, create the dshash table. XXX: It'd be nice
* if there were dshash_create_in_place().
*/
dsh = dshash_create(dsa, &dsh_params, 0);
dsh = dshash_create(dsa, &dsh_params, NULL);
ctl->hash_handle = dshash_get_hash_table_handle(dsh);
/* lift limit set above */