c8h4/postgresql
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Handle posix_fallocate() errors.

Browse source 
On some platforms, posix_fallocate() is available but may still return
EINVAL if the underlying filesystem does not support it.  So, in case
of an error, fall through to the alternate implementation that just
writes zeros.

Per buildfarm failure and analysis by Tom Lane.
This commit is contained in:
Jeff Davis 2013-07-06 13:46:04 -07:00
parent 43c3aab123
commit 5b571bb8c8
1 changed files with 12 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
src/backend/access/transam/xlog.c
View file

@ -2259,6 +2259,7 @@ XLogFileInit(XLogSegNo logsegno, bool *use_existent, bool use_lock)
XLogSegNo installed_segno;
int max_advance;
int fd;
bool zero_fill = true;
XLogFilePath(path, ThisTimeLineID, logsegno);
@ -2301,24 +2302,18 @@ XLogFileInit(XLogSegNo logsegno, bool *use_existent, bool use_lock)
errmsg("could not create file \"%s\": %m", tmppath)));
#ifdef HAVE_POSIX_FALLOCATE
{
errno = posix_fallocate(fd, 0, XLogSegSize);
/*
* If posix_fallocate() is available and succeeds, then the file is
* properly allocated and we don't need to zero-fill it (which is less
* efficient). In case of an error, fall back to writing zeros, because on
* some platforms posix_fallocate() is available but will not always
* succeed in cases where zero-filling will.
*/
if (posix_fallocate(fd, 0, XLogSegSize) == 0)
zero_fill = false;
#endif /* HAVE_POSIX_FALLOCATE */
if (errno)
{
int errno_saved = errno;
close(fd);
unlink(tmppath);
errno = errno_saved;
ereport(ERROR,
(errcode_for_file_access(),
errmsg("could not allocate space for file \"%s\" using posix_fallocate: %m",
tmppath)));
}
}
#else /* !HAVE_POSIX_FALLOCATE */
if (zero_fill)
{
/*
* Allocate a buffer full of zeros. This is done before opening the
@ -2366,7 +2361,6 @@ XLogFileInit(XLogSegNo logsegno, bool *use_existent, bool use_lock)
}
pfree(zbuffer);
}
#endif /* HAVE_POSIX_FALLOCATE */
if (pg_fsync(fd) != 0)
{