c8h4/postgresql
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

C comments: improve description of relfilenode uniqueness

Browse source 
Report by Antonin Houska
This commit is contained in:
Bruce Momjian 2014-03-08 12:20:30 -05:00
parent 11d205e2bd
commit 5024044a20
3 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/backend/catalog/catalog.c
View file

@ -408,8 +408,8 @@ GetNewOidWithIndex(Relation relation, Oid indexId, AttrNumber oidcolumn)
/* /*
* GetNewRelFileNode * GetNewRelFileNode
* Generate a new relfilenode number that is unique within the given * Generate a new relfilenode number that is unique within the
* tablespace. * database of the given tablespace.
* *
* If the relfilenode will also be used as the relation's OID, pass the * If the relfilenode will also be used as the relation's OID, pass the
* opened pg_class catalog, and this routine will guarantee that the result * opened pg_class catalog, and this routine will guarantee that the result

4
src/backend/commands/tablecmds.c
View file

@ -9078,8 +9078,8 @@ ATExecSetTableSpace(Oid tableOid, Oid newTableSpace, LOCKMODE lockmode)
FlushRelationBuffers(rel); FlushRelationBuffers(rel);
/* /*
* Relfilenodes are not unique across tablespaces, so we need to allocate * Relfilenodes are not unique in databases across tablespaces, so we
* a new one in the new tablespace. * need to allocate a new one in the new tablespace.
*/ */
newrelfilenode = GetNewRelFileNode(newTableSpace, NULL, newrelfilenode = GetNewRelFileNode(newTableSpace, NULL,
rel->rd_rel->relpersistence); rel->rd_rel->relpersistence);

3
src/include/storage/relfilenode.h
View file

@ -55,7 +55,8 @@ typedef enum ForkNumber
* relNode identifies the specific relation. relNode corresponds to * relNode identifies the specific relation. relNode corresponds to
* pg_class.relfilenode (NOT pg_class.oid, because we need to be able * pg_class.relfilenode (NOT pg_class.oid, because we need to be able
* to assign new physical files to relations in some situations). * to assign new physical files to relations in some situations).
* Notice that relNode is only unique within a particular tablespace. * Notice that relNode is only unique within a database in a particular
* tablespace.
* *
* Note: spcNode must be GLOBALTABLESPACE_OID if and only if dbNode is * Note: spcNode must be GLOBALTABLESPACE_OID if and only if dbNode is
* zero. We support shared relations only in the "global" tablespace. * zero. We support shared relations only in the "global" tablespace.