c8h4/postgresql
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

MSVC: Build ~35% faster by calling dumpbin just once per directory.

Browse source 
Peifeng Qiu

Discussion: https://postgr.es/m/CABmtVJiKXQjast0dQD-8KAtfm8XmyYxo-4Dc7+M+fBr8JRTqkw@mail.gmail.com
This commit is contained in:
Noah Misch 2019-05-03 21:56:47 -07:00
parent 726cc4242a
commit 34ff542a71
1 changed files with 6 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/tools/msvc/gendef.pl
View file

@ -1,7 +1,6 @@
use strict;
use warnings;
use 5.8.0;
use File::Spec::Functions qw(splitpath catpath);
use List::Util qw(max);
my @def;
@ -12,17 +11,6 @@ my @def;
# src/tools/msvc/gendef.pl
#
sub dumpsyms
{
my ($objfile, $symfile) = @_;
my ($symvol, $symdirs, $symbase) = splitpath($symfile);
my $tmpfile = catpath($symvol, $symdirs, "symbols.out");
system("dumpbin /symbols /out:$tmpfile $_ >NUL")
&& die "Could not call dumpbin";
rename($tmpfile, $symfile);
return;
}
# Given a symbol file path, loops over its contents
# and returns a list of symbols of interest as a dictionary
# of 'symbolname' -> symtype, where symtype is:
@ -177,15 +165,12 @@ print "Generating $defname.DEF from directory $ARGV[0], platform $platform\n";
my %def = ();
while (<$ARGV[0]/*.obj>) ## no critic (RequireGlobFunction);
{
my $objfile = $_;
my $symfile = $objfile;
$symfile =~ s/\.obj$/.sym/i;
dumpsyms($objfile, $symfile);
print ".";
extract_syms($symfile, \%def);
}
my $symfile = "$ARGV[0]/all.sym";
my $tmpfile = "$ARGV[0]/tmp.sym";
system("dumpbin /symbols /out:$tmpfile $ARGV[0]/*.obj >NUL")
&& die "Could not call dumpbin";
rename($tmpfile, $symfile);
extract_syms($symfile, \%def);
print "\n";
writedef($deffile, $platform, \%def);