c8h4/postgresql
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

GIN index build's allocatedMemory counter needs to be long, not uint32.

Browse source 
Else, in a 64-bit machine with maintenance_work_mem set to above 4Gb,
the counter overflows and we never recognize having reached the
maintenance_work_mem limit.  I believe this explains out-of-memory
failure recently reported by Sean Davis.

This is a bug, so backpatch to 8.2.
This commit is contained in:
Tom Lane 2007-11-16 21:50:06 +00:00
parent 015794541d
commit 16dcd5e5ce
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/include/access/gin.h
View file

@ -4,7 +4,7 @@
*
* Copyright (c) 2006-2007, PostgreSQL Global Development Group
*
* $PostgreSQL: pgsql/src/include/access/gin.h,v 1.14 2007/11/15 21:14:42 momjian Exp $
* $PostgreSQL: pgsql/src/include/access/gin.h,v 1.15 2007/11/16 21:50:06 tgl Exp $
*--------------------------------------------------------------------------
*/
@ -453,7 +453,7 @@ typedef struct
uint32 maxdepth;
EntryAccumulator **stack;
uint32 stackpos;
uint32 allocatedMemory;
long allocatedMemory;
uint32 length;
EntryAccumulator *entryallocator;