c8h4/postgresql
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Fix portability bug in gin_page_opaque_info().

Browse source 
Somebody apparently thought that "if Int32GetDatum is good,
Int64GetDatum must be better".  Per buildfarm failures now
that Peter has added some regression tests here.
This commit is contained in:
Tom Lane 2016-11-02 00:09:27 -04:00
parent f7c9a6e083
commit 14ee35799f
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
contrib/pageinspect/ginfuncs.c
View file

@ -100,7 +100,7 @@ gin_page_opaque_info(PG_FUNCTION_ARGS)
GinPageOpaque opaq;
HeapTuple resultTuple;
Datum values[3];
bool nulls[10];
bool nulls[3];
Datum flags[16];
int nflags = 0;
uint16 flagbits;
@ -152,9 +152,9 @@ gin_page_opaque_info(PG_FUNCTION_ARGS)
memset(nulls, 0, sizeof(nulls));
values[0] = Int64GetDatum(opaq->rightlink);
values[1] = Int64GetDatum(opaq->maxoff);
values[2] = PointerGetDatum(
construct_array(flags, nflags, TEXTOID, -1, false, 'i'));
values[1] = Int32GetDatum(opaq->maxoff);
values[2] = PointerGetDatum(construct_array(flags, nflags,
TEXTOID, -1, false, 'i'));
/* Build and return the result tuple. */
resultTuple = heap_form_tuple(tupdesc, values, nulls);