btrfs-progs/tune
Qu Wenruo f61b90aff9 btrfs-progs: make usage call properly return an exit value
[BUG]
Currently cli/009 test case failed with different exit number:

  ====== RUN CHECK /home/adam/btrfs-progs/btrfstune --help
  usage: btrfstune [options] device
  [...]
  failed: /home/adam/btrfs-progs/btrfstune --help
  test failed for case 009-btrfstune

[CAUSE]
In tune/main.c, we have the following call on usage():

  static void print_usage(int ret)
  {
	usage(&tune_cmd);
	exit(ret);
  }

However usage() itself would always call exit(1):

  void usage(const struct cmd_struct *cmd)
  {
	usage_command_usagestr(cmd->usagestr, NULL, 0, true, true);
	exit(1);
  }

This makes prevents any caller of usage() to modify its exit number.

[FIX]
Add a new argument @error for print_usage(), so we can properly return 0
for -h/--help usage.

Signed-off-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
2023-02-28 20:11:23 +01:00
..
change-csum.c btrfs-progs: tune: update checksum conversion 2023-02-28 20:11:22 +01:00
change-metadata-uuid.c btrfs-progs: tune: fix typos and mistakes in messages 2023-02-28 19:49:31 +01:00
change-uuid.c btrfs-progs: tune: fix typos and mistakes in messages 2023-02-28 19:49:31 +01:00
convert-bgt.c btrfs-progs: tune: fix typos and mistakes in messages 2023-02-28 19:49:31 +01:00
main.c btrfs-progs: make usage call properly return an exit value 2023-02-28 20:11:23 +01:00
seeding.c btrfs-progs: tune: factor out seeding to own file 2023-02-18 17:43:04 +01:00
tune.h btrfs-progs: tune: update checksum conversion 2023-02-28 20:11:22 +01:00