Development of userspace BTRFS tools
Find a file
Anand Jain 485fceec8d btrfs-progs: register device after successfully changing the fsid
Testing with the fstests config option POST_MKFS_CMD="btrfstune -m"
reported failure, as shown below:

  ./check btrfs/003

  [111.635618] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 1 transid 6 /dev/sdb2 scanned by systemd-udevd (1117)
  [111.642199] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 2 transid 6 /dev/sdb3 scanned by systemd-udevd (1114)
  [111.660882] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 3 transid 6 /dev/sdb5 scanned by systemd-udevd (1116)
  [111.672623] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 4 transid 6 /dev/sdb6 scanned by systemd-udevd (993)
  [111.701301] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 6 transid 6 /dev/sdb8 scanned by systemd-udevd (1080)
  [111.706513] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 5 transid 6 /dev/sdb7 scanned by systemd-udevd (1117)
  [111.716532] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 7 transid 6 /dev/sdb9 scanned by systemd-udevd (1114)
  [111.721253] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 8 transid 6 /dev/sdb10 scanned by mkfs.btrfs (1504)
  [112.405186] BTRFS: device fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e devid 4 transid 8 /dev/sdb6 scanned by systemd-udevd (1117)
  [112.422104] BTRFS: device fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e devid 6 transid 8 /dev/sdb8 scanned by systemd-udevd (1523)
  [112.448355] BTRFS: device fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e devid 1 transid 8 /dev/sdb2 scanned by systemd-udevd (1115)
  [112.456126] BTRFS error: device /dev/sdb3 belongs to fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e, and the fs is already mounted
  [112.461299] BTRFS error: device /dev/sdb7 belongs to fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e, and the fs is already mounted
  [112.465690] BTRFS info (device sdb2): using crc32c (crc32c-generic) checksum algorithm
  [112.468758] BTRFS info (device sdb2): using free space tree
  [112.471318] BTRFS error: device /dev/sdb9 belongs to fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e, and the fs is already mounted
  [112.475962] BTRFS error: device /dev/sdb10 belongs to fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e, and the fs is already mounted
  [112.481934] BTRFS error: device /dev/sdb5 belongs to fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e, and the fs is already mounted
  [112.494614] BTRFS error (device sdb2): devid 2 uuid 99a57db7-2ef6-4240-a700-07ee7e64fb36 is missing
  [112.497834] BTRFS error (device sdb2): failed to read chunk tree: -2
  [112.507705] BTRFS error (device sdb2): open_ctree failed

The original fsid created by mkfs was a6599a65-8b6d-4156-bb55-0a3a2f0eae9d,
and the fsid created by the btrfstune -m option was
1b3bacbf-14db-49c9-a3ef-547998aacc4e.

During mount (after btrfstune -m), only 3 out of 8 devices were scanned
by systemd, while the rest were still being discovered. Consequently, the
mount command raced to find the missing devices. Since the mount command
in the kernel sets the flag fsdevices::opened, any further new alloc_device()
were blocked, resulting in the error "the fs is already mounted."

It is a good idea to register all devices after changing the fsid.
The previous registrations are already stale after changing the fsid.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>
2023-08-11 19:59:17 +02:00
.github/workflows btrfs-progs: ci: upload coverage workflow results to codecov.io 2023-07-26 15:00:48 +02:00
check btrfs-progs: check: convert int to bool in a few helpers 2023-07-27 14:45:29 +02:00
ci btrfs-progs: ci: update maintenance scripts 2023-07-27 15:42:40 +02:00
cmds btrfs-progs: list-chunks: rename variables, adjust LNumber starting point 2023-07-27 14:45:29 +02:00
common btrfs-progs: help: indent option description newlines 2023-07-27 14:45:29 +02:00
config btrfs-progs: build: reuse config/ directory for m4 macros 2023-05-26 21:08:17 +02:00
convert btrfs-progs: convert: follow the default free space tree setting 2023-06-01 01:42:03 +02:00
crypto btrfs-progs: crypto: declare SHA256 x86 optimized implementation 2023-05-26 18:02:31 +02:00
Documentation btrfs-progs: docs: update doc style and conventions 2023-07-27 14:45:29 +02:00
image btrfs-progs: rename struct open_ctree_flags to open_ctree_args 2023-07-26 15:00:47 +02:00
include btrfs-progs: partial sync of ctree.c from kernel 2023-05-26 18:02:31 +02:00
kernel-lib btrfs-progs: sync tree-checker.[ch] from kernel 2023-05-26 18:02:30 +02:00
kernel-shared btrfs-progs: drop argument devid from device_list_add 2023-07-26 15:00:48 +02:00
libbtrfs libbtrfs: remove the support for fs without uuid tree 2023-05-26 18:02:31 +02:00
libbtrfsutil btrfs-progs: sync DEV_INFO ioctl from kernel 2023-03-21 02:55:56 +01:00
mkfs btrfs-progs: mkfs: convert int to bool in a few helpers 2023-07-27 14:45:29 +02:00
tests btrfs-progs: tests: check if enqueued replace over replace waits 2023-07-27 14:45:29 +02:00
tune btrfs-progs: register device after successfully changing the fsid 2023-08-11 19:59:17 +02:00
.editorconfig btrfs-progs: add basic .editorconfig 2020-08-31 17:01:02 +02:00
.gitignore btrfs-progs: build: reuse config/ directory for m4 macros 2023-05-26 21:08:17 +02:00
64-btrfs-dm.rules btrfs-progs: udev: add rules for dm devices 2016-06-01 14:56:56 +02:00
64-btrfs-zoned.rules btrfs-progs: add udev rule to use mq-deadline on zoned btrfs 2022-02-01 18:41:43 +01:00
autogen.sh btrfs-progs: build: reuse config/ directory for m4 macros 2023-05-26 21:08:17 +02:00
btrfs-completion btrfs-progs: completion: include files in "du" completion 2023-04-26 12:39:16 +02:00
btrfs-corrupt-block.c btrfs-progs: replace write_and_map_eb() by write_data_to_disk() 2023-05-26 18:02:31 +02:00
btrfs-crc.c btrfs-progs: move crc32c implementation to crypto/ 2019-11-18 19:20:02 +01:00
btrfs-debugfs btrfs-progs: port btrfs-debugfs to python3 2020-07-02 22:24:33 +02:00
btrfs-find-root.c btrfs-progs: add btrfs-find-root to btrfs.box 2023-07-26 15:00:48 +02:00
btrfs-fragments.c btrfs-progs: sync uapi/btrfs.h into btrfs-progs 2023-05-26 18:02:28 +02:00
btrfs-map-logical.c btrfs-progs: map-logical: convert help text to option formatter 2023-02-28 20:11:24 +01:00
btrfs-sb-mod.c btrfs-progs: build: use plain fcntl.h instead of sys/fcntl.h 2023-02-28 19:49:30 +01:00
btrfs-select-super.c btrfs-progs: select-super: convert help text to option formatter 2023-02-28 20:11:24 +01:00
btrfs.c btrfs-progs: add btrfs-find-root to btrfs.box 2023-07-26 15:00:48 +02:00
CHANGES btrfs-progs: update CHANGES for 6.3.3 2023-07-27 14:32:00 +02:00
configure.ac btrfs-progs: build: reuse config/ directory for m4 macros 2023-05-26 21:08:17 +02:00
COPYING fix COPYING 2007-06-12 15:41:08 -04:00
fsck.btrfs btrfs-progs: fsck.btrfs: Fix bashism and bad getopts processing 2015-05-21 16:53:44 +02:00
inject-error btrfs-progs: add error injection helper script 2023-07-27 14:45:29 +02:00
INSTALL btrfs-progs: docs: fixups, references 2023-06-01 20:50:04 +02:00
Makefile btrfs-progs: add simple error injection framework 2023-07-27 14:45:29 +02:00
Makefile.extrawarn btrfs-progs: build: disable -Waddress-of-packed-member by default 2019-06-14 15:09:53 +02:00
Makefile.inc.in btrfs-progs: fix detection of accelerated implementation. 2023-03-01 15:10:21 +01:00
quick-test.c btrfs-progs: kernel-lib: remove radix-tree 2022-10-11 09:08:07 +02:00
README.md btrfs-progs: ci: upload coverage workflow results to codecov.io 2023-07-26 15:00:48 +02:00
show-blocks btrfs-progs: Remove btrfs-debug-tree command 2018-04-24 13:00:10 +02:00
VERSION Btrfs progs v6.3.3 2023-07-27 14:33:30 +02:00

Btrfs-progs

devel coverage codecov static release

Userspace utilities to manage btrfs filesystems. License: GPLv2.

Btrfs is a copy on write (COW) filesystem for Linux aimed at implementing advanced features while focusing on fault tolerance, repair and easy administration.

This repository hosts following utilities and also documentation:

See INSTALL for build instructions, tests/README.md for testing information and ci/README.md for CI information.

Release cycle

The major version releases are time-based and follow the cycle of the linux kernel releases. The cycle usually takes 2 months. A minor version releases may happen in the meantime if there are bug fixes or minor useful improvements queued.

The release tags are signed with a GPG key ID F2B4 1200 C54E FB30 380C 1756 C565 D5F9 D76D 583B, release tarballs are hosted at kernel.org. See file CHANGES or changelogs on RTD.

Reporting bugs

There are several ways, each has its own specifics and audience that can give feedback or work on a fix. The following list is sorted in the order of preference:

Development

The development takes place in the mailing list (linux-btrfs@vger.kernel.org) or at github (issues, pull requests). Changes should be split to logical parts if possible, documentation may be included in the same patch as to code or separately.

The development model of btrfs-progs shares a lot with the kernel model. The

  • one logical change per patch: eg. not mixing bugfixes, cleanups, features etc., sometimes it's not clear and will be usually pointed out during reviews
  • proper subject line: eg. prefix with btrfs-progs: subpart, ... , descriptive yet not too long, see git log --oneline for some inspiration
  • proper changelog: the changelogs are often missing or lacking explanation why the change was made, or how is something broken, what are user-visible effects of the bug or the fix, how does an improvement help or the intended usecase
  • the Signed-off-by line is not mandatory for less significant changes (typos, documentation) but is desired as this documents who authored the change, you can read more about the The Developer's Certificate of Origin (chapter 11)
    • if you are not used to the signed-off style, your contributions won't be rejected just because of it's missing, the Author: tag will be added as a substitute in order to allow contributions without much bothering with formalities

Source code coding style and preferences follow the kernel coding style. You can find the editor settings in .editorconfig and use the EditorConfig plugin to let your editor use that, or update your editor settings manually.

Testing

The testing documentation can be found in tests/ and continuous integration/container images in ci/.

Documentation updates

Documentation fixes or updates do not need much explanation so sticking to the code rules in the previous section is not necessary. GitHub pull requests are OK, patches could be sent to me directly and not required to be also in the mailinglist. Pointing out typos via IRC also works, although might get accidentally lost in the noise.

Documentation sources are written in RST and built by sphinx.

Third-party sources

Build dependencies are listed in INSTALL. Implementation of checksum/hash functions is provided by copies of the respective sources to avoid adding dependencies that would make deployments in rescue or limited environments harder. The implementations are portable and there are optimized versions for some architectures. Optionally it's possible to use libgcrypt, libsodium or libkcapi implementations.

Some other code is borrowed from kernel, eg. the raid5 tables or data structure implementation (list, rb-tree).

References