c8h4/btrfs-progs
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity
btrfs-progs/cmds
History
David Sterba 4b09ba4b78 btrfs-progs: restore: fix chown of a symlink 
User reports:

"When I execute btrfs restore -S to restore a symlink, it prints:

SYMLINK: 'dest/path/of/symlink' => 'symlink/target'
Failed to change owner: Bad file descriptor

And at cmds-restore.c#L937:

ret = fchownat(-1, file, btrfs_inode_uid(path.nodes[0], inode_item),
                           btrfs_inode_gid(path.nodes[0], inode_item),
                           AT_SYMLINK_NOFOLLOW);
"

The -1 is indeed a bad descriptor, and should be probably AT_FDCWD as
this is documented. The path passed as 'file' is always absolute, so the
semantics are unaffected.

Issue: #183
Signed-off-by: David Sterba <dsterba@suse.com>
2019-07-26 17:46:43 +02:00
..
balance.c btrfs-progs: move utils.[ch] to common/ 2019-07-03 20:49:04 +02:00
commands.h btrfs-progs: help: define helper for command with flags 2019-07-03 20:49:04 +02:00
device.c btrfs-progs: utils: split device scanning functions to own file 2019-07-04 02:06:34 +02:00
filesystem-du.c btrfs-progs: fix helpinfo formats, short and options separation 2019-07-03 20:49:04 +02:00
filesystem-usage.c btrfs-progs: utils: split device handling functions to own file 2019-07-04 02:06:34 +02:00
filesystem-usage.h btrfs-progs: move all cmds-fi*.c to cmds/ 2019-07-03 20:49:03 +02:00
filesystem.c btrfs-progs: utils: split device scanning functions to own file 2019-07-04 02:06:34 +02:00
inspect-dump-super.c btrfs-progs: fix helpinfo formats, short and options separation 2019-07-03 20:49:04 +02:00
inspect-dump-tree.c btrfs-progs: dump-tree: add noscan option 2019-07-04 15:36:00 +02:00
inspect-tree-stats.c btrfs-progs: fix helpinfo formats, short and options separation 2019-07-03 20:49:04 +02:00
inspect.c btrfs-progs: fix helpinfo formats, short and options separation 2019-07-03 20:49:04 +02:00
property.c btrfs-progs: props: update help texts 2019-07-26 17:46:42 +02:00
qgroup.c btrfs-progs: fix helpinfo formats, short and options separation 2019-07-03 20:49:04 +02:00
quota.c btrfs-progs: move utils.[ch] to common/ 2019-07-03 20:49:04 +02:00
receive.c btrfs-progs: receive: get rid of unnecessary strdup() 2019-07-26 17:46:42 +02:00
replace.c btrfs-progs: utils: split device handling functions to own file 2019-07-04 02:06:34 +02:00
rescue-chunk-recover.c btrfs-progs: build: drop kernel-lib from -I and update paths 2019-07-03 20:49:04 +02:00
rescue-super-recover.c btrfs-progs: build: drop kernel-lib from -I and update paths 2019-07-03 20:49:04 +02:00
rescue.c btrfs-progs: fix helpinfo formats, short and options separation 2019-07-03 20:49:04 +02:00
rescue.h btrfs-progs: move cmds-rescue.c to cmds/ 2019-07-03 20:49:02 +02:00
restore.c btrfs-progs: restore: fix chown of a symlink 2019-07-26 17:46:43 +02:00
scrub.c btrfs-progs: scrub: fix status lines alignment 2019-07-26 17:46:43 +02:00
send.c btrfs-progs: utils: split path related utils to own file 2019-07-04 02:06:31 +02:00
subvolume.c btrfs-progs: utils: split device scanning functions to own file 2019-07-04 02:06:34 +02:00