c8h4/btrfs-progs
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

btrfs-progs: sb-mod: don't fixup checksum for read-only ops

Browse source 
On images with some damage and mismatching checksum the read operations
will fixup the checksum. This may not be desired and does not make much
sense for read anyway.

Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
David Sterba 2021-10-04 15:17:42 +02:00
parent dd8e7477f7
commit f7e4860e9f
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
btrfs-sb-mod.c
View file

@ -84,7 +84,6 @@ static u64 arg_strtou64(const char *str)
return value;
}
enum field_op {
OP_GET,
OP_SET,
@ -211,6 +210,11 @@ struct sb_field {
#define MOD_DEV_FIELD8(fname, set, val) \
MOD_DEV_FIELD_XX(fname, set, val, 8, "%hhu", "%hhx", unsigned char)
static bool op_is_write(enum field_op op)
{
return op != OP_GET;
}
static void mod_field_by_name(struct btrfs_super_block *sb, int set, const char *name,
u64 *val)
{
@ -362,13 +366,12 @@ int main(int argc, char **argv)
hdr = (struct btrfs_header *)buf;
/* verify checksum */
if (!check_csum_superblock(&hdr->csum)) {
printf("super block checksum does not match at offset %llu, will be corrected\n",
printf("super block checksum does not match at offset %llu, will be corrected after write\n",
(unsigned long long)off);
} else {
printf("super block checksum is ok\n");
}
sb = (struct btrfs_super_block *)buf;
changed = 0;
specidx = 0;
for (i = 2; i < argc; i++) {
@ -395,9 +398,11 @@ int main(int argc, char **argv)
}
}
changed = 0;
for (i = 0; i < specidx; i++) {
sb_edit(sb, &spec[i]);
changed = 1;
if (op_is_write(spec[i].fop))
changed = 1;
}
if (changed) {