c8h4/btrfs-progs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Btrfs-progs: fix reference check for roots in btrfsck

Browse source 
I noticed that I was getting these errors on a bigger file system with more
snapshots that had been removed.  This check is bogus since we won't inc
rec->found_ref if we don't find a REF_KEY _and_ a DIR_ITEM, so we only have to
worry about there being no references to a root if it actually has a root item.
If it doesn't then it's just referenced by things that will go no where anyway.
With this patch fsck no longer incorrectly complains about this file system
image I have.  Thanks,

Signed-off-by: Josef Bacik <jbacik@fusionio.com>
Signed-off-by: Chris Mason <chris.mason@fusionio.com>
This commit is contained in:
Josef Bacik 2013-06-05 10:02:59 -04:00 committed by Chris Mason
parent 7e992408e3
commit f00dd8386a
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
cmds-check.c
View file

@ -1637,6 +1637,14 @@ static int check_root_refs(struct btrfs_root *root,
rec->objectid); rec->objectid);
if (ret == 0) if (ret == 0)
continue; continue;
/*
* If we don't have a root item then we likely just have
* a dir item in a snapshot for this root but no actual
* ref key or anything so it's meaningless.
*/
if (!rec->found_root_item)
continue;
errors++; errors++;
fprintf(stderr, "fs tree %llu not referenced\n", fprintf(stderr, "fs tree %llu not referenced\n",
(unsigned long long)rec->objectid); (unsigned long long)rec->objectid);