c8h4/btrfs-progs
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

btrfs-progs: free allocated metadump structure on restore failure

Browse source 
Don't return w/ "metadump" still allocated

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
This commit is contained in:
Eric Sandeen 2013-03-04 16:39:55 -06:00 committed by David Sterba
parent c74beb90ea
commit dd53ec1c12
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
btrfs-image.c
View file

@ -765,11 +765,11 @@ static int wait_for_worker(struct mdrestore_struct *mdres)
static int restore_metadump(const char *input, FILE *out, int num_threads)
{
struct meta_cluster *cluster;
struct meta_cluster *cluster = NULL;
struct meta_cluster_header *header;
struct mdrestore_struct mdrestore;
u64 bytenr = 0;
FILE *in;
FILE *in = NULL;
int ret;
if (!strcmp(input, "-")) {
@ -797,14 +797,15 @@ static int restore_metadump(const char *input, FILE *out, int num_threads)
if (le64_to_cpu(header->magic) != HEADER_MAGIC ||
le64_to_cpu(header->bytenr) != bytenr) {
fprintf(stderr, "bad header in metadump image\n");
return 1;
ret = 1;
goto out;
}
ret = add_cluster(cluster, &mdrestore, &bytenr);
BUG_ON(ret);
wait_for_worker(&mdrestore);
}
out:
mdrestore_destroy(&mdrestore);
free(cluster);
if (in != stdin)