c8h4/btrfs-progs
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

btrfs-progs: tree-checker: dump the tree block when hitting an error

Browse source 
Unlike kernel where tree-checker would provide enough info so later we
can use "btrfs inspect dump-tree" to catch the offending tree block, in
progs we may not even have a btrfs to start "btrfs inspect dump-tree".
E.g during btrfs-convert.

To make later debuging easier, let's call btrfs_print_tree() for every
error we hit inside tree-checker.

Signed-off-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Qu Wenruo 2024-01-12 13:16:20 +10:30 committed by David Sterba
parent 8049446bb0
commit 94ace90508
1 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
kernel-shared/tree-checker.c
View file

@ -33,6 +33,7 @@
#include "kernel-shared/accessors.h" #include "kernel-shared/accessors.h"
#include "kernel-shared/file-item.h" #include "kernel-shared/file-item.h"
#include "kernel-shared/extent_io.h" #include "kernel-shared/extent_io.h"
#include "kernel-shared/print-tree.h"
#include "kernel-shared/uapi/btrfs.h" #include "kernel-shared/uapi/btrfs.h"
#include "kernel-shared/uapi/btrfs_tree.h" #include "kernel-shared/uapi/btrfs_tree.h"
#include "common/internal.h" #include "common/internal.h"
@ -95,6 +96,8 @@ static void generic_err(const struct extent_buffer *eb, int slot,
btrfs_header_level(eb) == 0 ? "leaf" : "node", btrfs_header_level(eb) == 0 ? "leaf" : "node",
btrfs_header_owner(eb), btrfs_header_bytenr(eb), slot, &vaf); btrfs_header_owner(eb), btrfs_header_bytenr(eb), slot, &vaf);
va_end(args); va_end(args);
btrfs_print_tree((struct extent_buffer *)eb, 0);
} }
/* /*
@ -123,6 +126,8 @@ static void file_extent_err(const struct extent_buffer *eb, int slot,
btrfs_header_owner(eb), btrfs_header_bytenr(eb), slot, btrfs_header_owner(eb), btrfs_header_bytenr(eb), slot,
key.objectid, key.offset, &vaf); key.objectid, key.offset, &vaf);
va_end(args); va_end(args);
btrfs_print_tree((struct extent_buffer *)eb, 0);
} }
/* /*
@ -183,6 +188,8 @@ static void dir_item_err(const struct extent_buffer *eb, int slot,
btrfs_header_owner(eb), btrfs_header_bytenr(eb), slot, btrfs_header_owner(eb), btrfs_header_bytenr(eb), slot,
key.objectid, &vaf); key.objectid, &vaf);
va_end(args); va_end(args);
btrfs_print_tree((struct extent_buffer *)eb, 0);
} }
/* /*
@ -669,6 +676,8 @@ static void block_group_err(const struct extent_buffer *eb, int slot,
btrfs_header_owner(eb), btrfs_header_bytenr(eb), slot, btrfs_header_owner(eb), btrfs_header_bytenr(eb), slot,
key.objectid, key.offset, &vaf); key.objectid, key.offset, &vaf);
va_end(args); va_end(args);
btrfs_print_tree((struct extent_buffer *)eb, 0);
} }
static int check_block_group_item(struct extent_buffer *leaf, static int check_block_group_item(struct extent_buffer *leaf,
@ -800,6 +809,8 @@ static void chunk_err(const struct extent_buffer *leaf,
BTRFS_CHUNK_TREE_OBJECTID, leaf->start, slot, BTRFS_CHUNK_TREE_OBJECTID, leaf->start, slot,
logical, &vaf); logical, &vaf);
va_end(args); va_end(args);
btrfs_print_tree((struct extent_buffer *)leaf, 0);
} }
/* /*
@ -1025,6 +1036,8 @@ static void dev_item_err(const struct extent_buffer *eb, int slot,
btrfs_header_owner(eb), btrfs_header_bytenr(eb), slot, btrfs_header_owner(eb), btrfs_header_bytenr(eb), slot,
key.objectid, &vaf); key.objectid, &vaf);
va_end(args); va_end(args);
btrfs_print_tree((struct extent_buffer *)eb, 0);
} }
static int check_dev_item(struct extent_buffer *leaf, static int check_dev_item(struct extent_buffer *leaf,
@ -1279,6 +1292,8 @@ static void extent_err(const struct extent_buffer *eb, int slot,
btrfs_header_level(eb) == 0 ? "leaf" : "node", btrfs_header_level(eb) == 0 ? "leaf" : "node",
eb->start, slot, bytenr, len, &vaf); eb->start, slot, bytenr, len, &vaf);
va_end(args); va_end(args);
btrfs_print_tree((struct extent_buffer *)eb, 0);
} }
static int check_extent_item(struct extent_buffer *leaf, static int check_extent_item(struct extent_buffer *leaf,