c8h4/btrfs-progs
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

btrfs-progs: handle internal errors in btrfs_assert_feature_buf_size()

Browse source 
The buffer size check is needed and has already caught problems when
adding the raid-stripe-tree, do a better error reporting.

Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
David Sterba 2024-03-15 00:23:29 +01:00
parent dbc7d6aa19
commit 949eb7599b
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
common/fsfeatures.c
View file

@ -312,12 +312,21 @@ void btrfs_assert_feature_buf_size(void)
for (i = 0; i < ARRAY_SIZE(mkfs_features); i++)
/* The extra 2 bytes are for the ", " prefix. */
total_size += strlen(mkfs_features[i].name) + 2;
BUG_ON(BTRFS_FEATURE_STRING_BUF_SIZE < total_size);
if (BTRFS_FEATURE_STRING_BUF_SIZE < total_size) {
internal_error("string buffer for freature list too small: want %d\n",
total_size);
abort();
}
total_size = 0;
for (i = 0; i < ARRAY_SIZE(runtime_features); i++)
total_size += strlen(runtime_features[i].name) + 2;
BUG_ON(BTRFS_FEATURE_STRING_BUF_SIZE < total_size);
if (BTRFS_FEATURE_STRING_BUF_SIZE < total_size) {
internal_error("string buffer for freature list too small: want %d\n",
total_size);
abort();
}
}
static size_t get_feature_array_size(enum feature_source source)