c8h4/btrfs-progs
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

btrfs-progs: tests: fsck/037-freespacetree-repair workaround for missing kernel fix

Browse source 
Kernel patch ff51bf02d107 ("btrfs: block-group: fix free-space bitmap
threshold") is needed to exercise both branches of the test, this can be
detected by lack of the objectid and offset parsed from the dump.

Issue: #288
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
David Sterba 2020-08-28 18:21:30 +02:00
parent cd905192b5
commit 7d2abf432d
1 changed files with 17 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
tests/fsck-tests/037-freespacetree-repair/test.sh
View file

@ -3,6 +3,9 @@
# btrfs check is able to repair it. This tests correct detection/repair of # btrfs check is able to repair it. This tests correct detection/repair of
# both a FREE_SPACE_EXTENT based FST and a FREE_SPACE_BITMAP based FST. # both a FREE_SPACE_EXTENT based FST and a FREE_SPACE_BITMAP based FST.
# Note: this needs a patched kernel to exercise extents and bitmaps
# ff51bf02d107 ("btrfs: block-group: fix free-space bitmap threshold")
source "$TEST_TOP/common" source "$TEST_TOP/common"
setup_root_helper setup_root_helper
@ -32,6 +35,10 @@ corrupt_fst_item()
offset=$("$TOP/btrfs" inspect-internal dump-tree -t 10 "$TEST_DEV" | \ offset=$("$TOP/btrfs" inspect-internal dump-tree -t 10 "$TEST_DEV" | \
grep -o "[[:digit:]]* FREE_SPACE_BITMAP [[:digit:]]*" | \ grep -o "[[:digit:]]* FREE_SPACE_BITMAP [[:digit:]]*" | \
cut -d' ' -f3 | tail -2 | head -1) cut -d' ' -f3 | tail -2 | head -1)
if [ -z "$objectid" -o -z "$offset" ]; then
_log_skipped "No bitmap to corrupt found, needs kernel patch"
return 1
fi
_log "Corrupting $objectid,FREE_SPACE_BITMAP,$offset" _log "Corrupting $objectid,FREE_SPACE_BITMAP,$offset"
elif [[ $type == "extent" ]]; then elif [[ $type == "extent" ]]; then
type=199 type=199
@ -41,6 +48,10 @@ corrupt_fst_item()
offset=$("$TOP/btrfs" inspect-internal dump-tree -t 10 "$TEST_DEV" | \ offset=$("$TOP/btrfs" inspect-internal dump-tree -t 10 "$TEST_DEV" | \
grep -o "[[:digit:]]* FREE_SPACE_EXTENT [[:digit:]]*" | \ grep -o "[[:digit:]]* FREE_SPACE_EXTENT [[:digit:]]*" | \
cut -d' ' -f3 | tail -2 | head -1) cut -d' ' -f3 | tail -2 | head -1)
if [ -z "$objectid" -o -z "$offset" ]; then
_log_skipped "No extent to corrupt found, needs kernel patch"
return 1
fi
_log "Corrupting $objectid,FREE_SPACE_EXTENT,$offset" _log "Corrupting $objectid,FREE_SPACE_EXTENT,$offset"
else else
_fail "Unknown item type for corruption" _fail "Unknown item type for corruption"
@ -69,8 +80,9 @@ done
run_check_umount_test_dev run_check_umount_test_dev
# now corrupt one of the bitmap items # now corrupt one of the bitmap items
corrupt_fst_item "bitmap" if corrupt_fst_item "bitmap"; then
check_image "$TEST_DEV" check_image "$TEST_DEV"
fi
# change the freespace such that we now have at least one free_space_extent # change the freespace such that we now have at least one free_space_extent
# object # object
@ -80,5 +92,6 @@ run_check $SUDO_HELPER fallocate -l 50m "$TEST_MNT/file"
run_check_umount_test_dev run_check_umount_test_dev
# now corrupt an extent # now corrupt an extent
corrupt_fst_item "extent" if corrupt_fst_item "extent"; then
check_image "$TEST_DEV" check_image "$TEST_DEV"
fi